feat(monitor): add search-target support to monitor create#142
Merged
Conversation
Search monitors (type:"search") are implemented in the API but undocumented. Add --queries/--search-window/--max-results/--include-domains/--exclude-domains flags, build the search target in buildCreateBody, and require --goal for search monitors (the API mandates a non-empty goal). Includes tests.
Clarify messaging by changing references from 'search monitors' to 'web monitors'. Update the thrown error in buildCreateBody to "--goal is required for web monitors (--queries)" and adjust the corresponding unit test to expect the new wording. This makes it clearer that a goal is required when creating web monitors with queries (the API auto-enables the AI judge). Files modified: src/commands/monitor.ts, src/__tests__/commands/monitor.test.ts.
# Conflicts: # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search monitors (type:"search") are implemented in the API but undocumented. Add --queries/--search-window/--max-results/--include-domains/--exclude-domains flags, build the search target in buildCreateBody, and require --goal for search monitors (the API mandates a non-empty goal). Includes tests.